Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTO enabled by default if supported; selecting ar, ranlib implementat… #678

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

mngr777
Copy link
Contributor

@mngr777 mngr777 commented Mar 14, 2022

…ion based on compiler vendor

Selecting ar (llvm-ar, gcc-ar) and ranlib (llvg-ranlib, gcc-ranlib) matching selected compiler for gcc and Clang.
This allows to enable LTO by default.

@mngr777 mngr777 marked this pull request as draft March 14, 2022 12:15
@@ -178,7 +178,7 @@ static void do_test_u64_roundtrip(uint64_t i64_in)
{
uint8_t buffer[16];
uint64_t i64_out;
size_t size_in, size_out;
size_t size_in, size_out = -1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size_t is unsigned, can't be -1

…ion based on compiler vendor; lwgeom, raster: possible uninitialized variable fixes
@mngr777 mngr777 changed the title LTO enabled by default if supported; selecting ar, ranlig implementat… LTO enabled by default if supported; selecting ar, ranlib implementat… Mar 15, 2022
@mngr777 mngr777 marked this pull request as ready for review March 15, 2022 12:06
@mngr777
Copy link
Contributor Author

mngr777 commented Mar 15, 2022

Failing tests seem to be due to missing GDAL (not sure about "CI (pg13-geos39-gdal31-proj71, usan_gcc)" https://github.com/postgis/postgis/runs/5552651399?check_suite_focus=true).
Build does not start on FreeBSD test servers.

@strk strk merged commit 5d0da12 into postgis:master Mar 22, 2022
@mngr777 mngr777 deleted the enable-lto-default branch May 14, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants